CSS for all diagram items #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
approved these changes
Jan 14, 2024
danyeaw
approved these changes
Jan 14, 2024
2 tasks
amolenaar
force-pushed
the
css-diagram-general
branch
3 times, most recently
from
58fdc74
to
5d7b180
Compare
amolenaar
commented
Jan 21, 2024
amolenaar
commented
Jan 21, 2024
|
@danyeaw I added a lot more changes to this PR. |
Similar to Component
Otherwise padding is applied multiple times.
Now all other elements can start using `text_name()` to display their name.
Now all names in all elements can be styled.
Needed for regions
Top compartment is not similar to classifiers.
Just define it in CSS.
Now we have to use CSS.
Group by language and add a few improvements (nested classifiers, metadata).
Let's focus on (classifier) compartments here.
amolenaar
force-pushed
the
css-diagram-general
branch
from
efcb26b
to
54aa687
Compare
danyeaw
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks @amolenaar!! This is such a nice improvement, it will be much easier to create new toolboxes and maintain the ones we have with all the style centralized like this! 🤩
danyeaw
added
feature
|
A next step may be to create some style sheets, so users can pick from a few predefined styles. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3023
What is the new behavior?
New CSS capabilities:
iconnodes.compartmentnodes.:first-childselector.stereotype_watches()function where possibleDoes this PR introduce a breaking change?
Other information
text-alignandfont-*leak through to child items in a diagram.