Install Poetry as part of the RtD build #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
readthedocs-poetry
branch
from
e44cced
to
ad45fa1
Compare
Same as all other groups. Now we do not have to carry docs extras around.
amolenaar
force-pushed
the
readthedocs-poetry
branch
from
4bac7b7
to
6bb7002
Compare
danyeaw
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We're using optional dependencies to define the dependencies for our documentation generation on Read the Docs. This looks a bit out of order, since there's no use for those optional dependencies, except for the documentation generation.
What is the new behavior?
Use Poetry. Now
docsis just a Poetry group, like any other group.I think this is more consistent.
Does this PR introduce a breaking change?
Other information