Make greeter window insensitive when a model is selected #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small quality of life thing, that provides feedback when a user clicks on a recent model or template.
|
Hi @amolenaar, I think I am being a bit dense on this one, but I don't see any difference in behavior between this branch and main. Could you please explain more about what I am supposed to see? |
|
The change is minimal. With this PR, the greeter window will be made grayed out when you select a model. I change the priority f the load function. Now it should be more visible that the greeter window is made insensitive. |
danyeaw
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a model is big, a user does not get any feedback when it's selected in the greeter.
What is the new behavior?
A small quality of life thing, that provides feedback when a user clicks on a recent model or template.
Does this PR introduce a breaking change?
Other information