-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show CSS nodes below style sheet editor #3040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request introduces a feature that displays the CSS node layout for the currently selected element in the diagram below the style editor. This enhancement aims to make it easier for users to understand the CSS nodes associated with diagram items.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the addition of the
diagrams
parameter to thePreferencesStack
constructor is well-documented, as it signifies a more significant role for diagrams in the preferences functionality. - Verify that all methods using
_current_item
properly handle the case when it isNone
to prevent potentialNoneType
errors. - Consider adding an unsubscribe call for
_selection_changed
in theclose
method to avoid memory leaks or unintended behavior after thePreferencesStack
is closed. - Review the overall impact of the changes on the application to ensure that the new behavior integrates smoothly with existing features.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
This will be very helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think this needs a TWIG mention 😉
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It's hard to guess what CSS nodes are part of an item in a diagram.
Issue Number: #3023
What is the new behavior?
Below the style editor, a node layout is given for the currently selected element.