-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Gaphor REUSE compliant #3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request introduces REUSE compliance to the Gaphor project, ensuring explicit declaration of licenses used within the project. It includes updates to the GitHub Actions workflow for linting, modifications to the README to point to the correct license file, and adjustments to the packaging specifications to reflect the new license file location.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Consider pinning the version of 'reuse' in the GitHub Actions workflow to maintain consistency across builds.
- Ensure that the new license file paths are correct and that the LICENSES directory is properly included in the repository.
- Review the changes to ensure that they align with the REUSE specifications and that all necessary files are correctly annotated with their respective licenses.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Hey @amolenaar, great idea! One thing I have been thinking about for our Copyrights as well is to remove the ending date, so Copyright © starting year, instead of range of years, since I don't think the range is really needed. Also it might be more inclusive of additional contributors if we changed it to The Gaphor Project instead of you and me. What do you think? |
According to the REUSE docs, all versions (begin data, end data, begin-end data, no date) are all okay. I think it's a good idea to contribute it to The Gaphor Project. All contributors are in our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I added a few additional copyright updates for the Gaphor Development Team. I also added gaphorcss.lang to the dep5 file
0b1ae2c
to
7fa1b7e
Compare
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Add REUSE compliance to this project.
This makes it explicit which licenses are used where.
To avoid editing every file, I used the dep5 approach.
Does this PR introduce a breaking change?
Other information