Give the diagram a default "view" background #3042
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces a visual enhancement to the Gaphor application by applying a default 'view' background style to diagrams. This aims to improve the contrast between the diagram and the sidebar, addressing the issue of both elements using the same background color.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Verify that the new 'view' CSS class aligns with the existing project styling conventions and does not cause any unintended style conflicts with other UI components.
- Consider providing a before-and-after comparison in the PR description to clearly illustrate the visual enhancement for reviewers.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -115,6 +115,7 @@ def construct(self): | |||
| scrolled_window = Gtk.ScrolledWindow() | |||
| scrolled_window.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC) | |||
| scrolled_window.set_child(view) | |||
| scrolled_window.add_css_class("view") | |||
There was a problem hiding this comment.
suggestion (llm): Adding a CSS class to the scrolled_window is a good way to enhance the styling capabilities. Just ensure that the class name 'view' is consistent with the project's CSS naming conventions and that it doesn't inadvertently apply styles that conflict with other elements.
danyeaw
added
feature
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The contrast between the diagram and the side bar is a bit off, since both use the same background color.
What is the new behavior?
Use Adwaita's default "view" style as background for diagrams.
Does this PR introduce a breaking change?
Other information