Build our own Gaphor bootloader #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
force-pushed
the
build-pyinstaller-bootloader
branch
2 times, most recently
from
5edf8e4
to
f99b00d
Compare
Fix virus scanner false positives by building our own bootloader.
danyeaw
force-pushed
the
build-pyinstaller-bootloader
branch
from
f99b00d
to
1bc70ca
Compare
amolenaar
reviewed
Jan 27, 2024
danyeaw
commented
Jan 27, 2024
There was a problem hiding this comment.
@amolenaar, your tweaks look great to me, thanks for the teamwork 👍
|
Unfortunately, this didn't really improve the virus scanner performance, 5 of 64 reporting it as malicious: https://www.virustotal.com/gui/file/72abf7595357d36edb62d1288bd1bf4f2fb18971aa03ca3770ba61f9d11e7c19?nocache=1 |
|
It also shows detections in other libraries (cairo, harfbuzz). |
So we can use/inspect them separately.
8 tasks
|
Shall we merge this? I know it does not fix Gaphor flagged for viruses, but it feels good to be in control of this part of the delivery process 😄 . Maybe we should do the same for macOS. |
amolenaar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyInstaller bootloader is often flagged by virus scanners as a virus or trojan. This PR builds our own bootloader on CI on Windows which should have a different virus scanner signature than ones pre-built.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Avast, Windows Defender, AVG, Google Smartscanner, and others were detecting that Gaphor was a Trojan.
Issue Number: N/A
What is the new behavior?
All detect as clean.
Does this PR introduce a breaking change?
Other information