Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra diagram item tests #309

Merged
merged 30 commits into from May 9, 2020
Merged

Extra diagram item tests #309

merged 30 commits into from May 9, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the new behavior?

I created some tests that capture general rules.

It turned out DependencyItem and ImplementationItem should show a name and be editable.

NB. This PR builds on top of #305 .

Does this PR introduce a breaking change?

  • Yes
  • No

@danyeaw danyeaw added the chore Maintenance related PR label May 9, 2020
@danyeaw danyeaw added this to the 1.3 milestone May 9, 2020
@amolenaar
Update Elementfactory keys()/values()
825141e 
Use Python3 dict protocol compliant methods.
@amolenaar
Simplify storage logic
1fccc83 
Canvas items now always store references (no extra reference parameter).
@amolenaar
Can copy a single presentation element
3474c9f
@amolenaar
Make copies of diagram items
2e9dc38 
Still assumes the model will not change underneath.
@amolenaar
Copy model elements
ce31749
@amolenaar
Can copy simple elements with relationships
a6fc7bd
@amolenaar
Let load on properties emit events
4bb1e6a 
They're caught on Elementfactory level and it will allow us to paste
propertly.
@amolenaar
Clean up unsed do_notify parameter for property set methods
fb9a703
@amolenaar
Can in basis copy an assocation now
ebd9026 
Association should be copied along with its memberEnds.
@amolenaar
Do not persist empty association references
c408c5a
@amolenaar
Check if we handle aggregate associations well
76839a8
@amolenaar
Copy classes with attributes and operations
66acbce
@amolenaar
Copy interface elements
e308e96
@amolenaar
Refactor: remove duplication
780d63e
@amolenaar
Copy State items properly
363e4c6
@amolenaar
Add copy/paste for Connector
09feda5
@amolenaar
Add Port.encapsulatedClassifier
5eae66c 
So component paste action will set all properties right.
@amolenaar
Add type hints for recursemixin
1515dd6 
Now `cls.ownedAttribute[:].name` is typed.
@amolenaar
Upgrade Flake8 to 3.8.0a2
8365b46
@amolenaar
Copy interaction messages and exec-specs
5d223ce
@amolenaar
Copy simple items
6edcd9e
@amolenaar
When copying named elements, set namespace same as diagram
39b6923 
Tis way elements do not get "lost" when they do not have a namespace
attached.

Note that some elements are NamedElement's, yet are not added to the
right package. Those are left as is.
@amolenaar
Do not paste if buffer is empty
0ca2ef8
@amolenaar
Add a "cut" operation
74af7c4 
Now the trio is complete.
@amolenaar
Merge Initial and History pseudostate items in to one
7b4ad94 
They differentiate mainly on "kind" attribute.
@amolenaar
Add test to see if all diagram items are mapped to UML elements
4179925 
Pseudostate was the odd one out. Fixed in previous commit.
@amolenaar
Add test that ensure all named elements have Named presentations
b262a90 
The Named interface is used to tell the inline editor that the
name of the element can be changed.
@amolenaar
Check if Classifier presentations are Classified
e8d15b3
@amolenaar amolenaar merged commit a386843 into master May 9, 2020
@amolenaar amolenaar deleted the extra-diagramitem-tests branch May 9, 2020 21:16
@amolenaar amolenaar mentioned this pull request May 9, 2020
Closed
17 tasks
@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Maintenance related PR
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amolenaar @danyeaw