Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virus scan with VirusTotal to CI #3113

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Add virus scan with VirusTotal to CI #3113

merged 2 commits into from
Feb 23, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Feb 17, 2024

Since we have been having a lot of problems with false positives with virus scanners, this PR adds a scan with Virus Total each time we build the Windows installer. If it is a release, it adds links to the scan results.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added the chore Maintenance related PR label Feb 17, 2024
@danyeaw danyeaw force-pushed the virus-scan branch 6 times, most recently from a3dba34 to 368941b Compare February 18, 2024 01:47
@danyeaw danyeaw force-pushed the virus-scan branch 2 times, most recently from c23b697 to 12be52e Compare February 20, 2024 20:01
@danyeaw danyeaw merged commit 68a1ce6 into main Feb 23, 2024
19 checks passed
@danyeaw danyeaw deleted the virus-scan branch February 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants