Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom icon when placing icon on the diagram #312

Merged
merged 1 commit into from May 9, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

If you select a placement tool, you can not see that by the cursor in the diagram. This is inconvenient, esp. when you're using the keyboard shortcuts. At least, I found this slightly annoying last evening ;).

What is the new behavior?

When selecting a tool in the toolbox, the cursor in the diagram reflects this selction. This makes it easier to see what action will be performed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar added the feature A new feature label May 8, 2020
@amolenaar amolenaar added this to the 1.3 milestone May 8, 2020
@amolenaar amolenaar requested a review from danyeaw May 8, 2020 21:17
gaphor/ui/diagrampage.py Outdated Show resolved Hide resolved
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't realize how much I needed this! This is a great enhancement 🎉

@amolenaar
Copy link
Member Author

I noticed I missed this while tinkering with the SysML model 😄

@amolenaar amolenaar merged commit b32fb8b into master May 9, 2020
@amolenaar amolenaar deleted the custom-placement-cursor branch May 9, 2020 21:10
@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants