Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple notifier for file changes #3121

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Add simple notifier for file changes #3121

merged 1 commit into from
Feb 25, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Feb 20, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

No notification if a model has been changed from the outside.

Issue Number: #3078

What is the new behavior?

Show a notification when a file has changed:

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Feb 20, 2024
@amolenaar amolenaar force-pushed the notify-model-changed branch 3 times, most recently from b321932 to dd6bf26 Compare February 21, 2024 20:54
If a model is changed outside of the Gaphor session, a message
is shown. This message can be removed by saving the model (no
warning is shown), or by loading the changed model.
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Feb 25, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks great!

@danyeaw danyeaw merged commit f0e24b8 into main Feb 25, 2024
18 checks passed
@danyeaw danyeaw deleted the notify-model-changed branch February 25, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants