Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate section for examples and templates in Greeter #3134

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Feb 24, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Users have to clean the UML, SysML, and RAAML templates if they want to use only the structure.

Issue Number: #2905

What is the new behavior?

Templates should not contain additional elements.

The Examples for the same structure as the templates, but filled with example data.

I think examples do not need a separate title.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Templates should not contain additional elements.

The Examples for the same structure as the templates, but
filled with example data.
@github-actions github-actions bot added the python Pull requests that update Python code label Feb 24, 2024
Now we have better control over the spacing.
@amolenaar amolenaar linked an issue Feb 24, 2024 that may be closed by this pull request
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar, this is a nice solution!

@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Feb 25, 2024
@danyeaw danyeaw merged commit fccf556 into main Feb 25, 2024
19 checks passed
@danyeaw danyeaw deleted the templates-and-examples branch February 25, 2024 03:24
@danyeaw danyeaw changed the title Create separate section for examples and templates Create separate section for examples and templates in Greeter Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start with empty model or example already filled
2 participants