Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about CodeQL CODEQL_PYTHON variable #3141

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Feb 25, 2024

CodeQL runs are giving us the following warning:

We recommend that you remove the CODEQL_PYTHON environment variable from your workflow. This environment variable was originally used to specify a Python executable that included the dependencies of your Python code, however Python analysis no longer uses these dependencies.
If you used CODEQL_PYTHON to force the version of Python to analyze as, please use CODEQL_EXTRACTOR_PYTHON_ANALYSIS_VERSION instead, such as 'CODEQL_EXTRACTOR_PYTHON_ANALYSIS_VERSION=2.7' or 'CODEQL_EXTRACTOR_PYTHON_ANALYSIS_VERSION=3.11'.

Since we were using this variable to force the use of the poetry Python, this PR removes use of it.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Warnings during CodeQL builds

Issue Number: N/A

What is the new behavior?

No CodeQL warnings during builds

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added the chore Maintenance related PR label Feb 25, 2024
@amolenaar amolenaar merged commit 661cef4 into main Feb 25, 2024
19 checks passed
@amolenaar amolenaar deleted the remove-codeql-python-env branch February 25, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants