Clean up property pages #3144
Merged
Clean up property pages #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to split model and view based properties in the future.
This is more consistent, and will allow us to easily decouple the presentation updates from the model element editors later.
9 tasks
danyeaw
added
feature
danyeaw
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Hi @amolenaar, this is a really nice simplification - this gives the Property Pages a much cleaner look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Property editors are often (but not always) encapsulated in a
GtkExpander. There's little need for that, since the number of editors is not that long.Issue Number: N/A
What is the new behavior?
Simplify property editors.
Does this PR introduce a breaking change?
Other information
This will make it easier to split model and view based properties in the future. In the end we want to be able to use the property editor for elements selected in the Model Browser.