Copy paste with parent items

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

Items, part of a super item, such as Components in a Node, are not copied properly.

Issue Number: #286

What is the new behavior?

• When a nested item is copied, it's pasted in the same parent item
• When child and parent item are copied together, a new parent item is created and the child will be part of that

Note that items are still pasted relative to the item position (position to the parent). Gaphor still needs some work so pasted items are always pasted inside the canvas' view port.

Does this PR introduce a breaking change?

• Yes
• No

[danyeaw]

This look great! Do you know why the builds are failing?

[amolenaar]

It's failing when I update the relationship for UseCase.subject to bi-directional. Other end is Classifier.useCase.

[actionless]

thanks a lot! now it seems almost perfect, except for some small sporadic padding changes:

[actionless]

(looks like top and left padding are multiplied by 2)

[amolenaar]

Thanks a lot for testing this. I see what’s going on: as part of a paste action, the offset of the elements is changed by 10 pixels. This way it’s clear to a user the new item is pasted. Hoever, it also applies this offset to the nested items. That should not be the case, of course.

The offset should only be applied to elements if the parent element is not part of the past action.

[amolenaar]

Fixed it in 74c82d4.

[actionless]

i still find it a bit weird what the whole copy-pasted fragment is padded extra 10px, i'd probably would make some sort of dotted line highlight around pasted elements, unless you click once somewhere

but that's not a blocker anymore, thanks a lot for your work!