Refactor the main window to a .ui file #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comma is used for system preferences now.
Ths replaces our custom layout xml file.
Now we can control it form the main window. This should help if we transition to more modern Adwaita widgets.
amolenaar
force-pushed
the
mainwindow-ui
branch
from
1cd5798
to
0f90fc0
Compare
amolenaar
force-pushed
the
mainwindow-ui
branch
from
098b71b
to
83dc8ad
Compare
danyeaw
added
chore
danyeaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: related to #3177
What is the new behavior?
Instead of our custom layout markup, let's just put everything in the main window ui file.
This allows us to more easily refactor the UI and introduce Adwaita widgets.
Does this PR introduce a breaking change?
Other information