Adwaita window #3186
Merged
Adwaita window #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
adwaita-window
branch
from
a6a2f46
to
5ec94ba
Compare
amolenaar
force-pushed
the
adwaita-window
branch
3 times, most recently
from
ba1eac2
to
4180e74
Compare
|
@amolenaar I looked at this in both Linux and Windows, and I really like these proposed changes. They look modern and streamlined! |
Make Gaphor look more like an Adwaita app.
So there's more space to draw.
So things keep looking nice.
amolenaar
force-pushed
the
adwaita-window
branch
from
6fa7f4b
to
28fa294
Compare
Alike Gaphor on Linux/GNOME.
|
I think the window behaves as expected now. 
|
|
I get errors while loading the Not sure why, though. |
On macOS, the tmp folder is in /var, but it links to /private/var. The workdit is resolved to /private/var/..., so we should do the same for the filename we want to match.
Also for the merge request resolver, since the sidebar will not automatically resize.
amolenaar
force-pushed
the
adwaita-window
branch
from
72d64fd
to
2841990
Compare
Decoration-layout needs at least a colon in the string.
danyeaw
added
feature
danyeaw
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: fixes #3177
What is the new behavior?
Use Adwaita's OverlaySplitView for the right side bar. The left side bar is still a
Gtk.Paned, since that allows for resizing of the pane.Adw.ToolbarViewis used all over the place to have separated header bar sections.Does this PR introduce a breaking change?
Other information
Extra: I added a fix so
tests/run_with_merge_conflict.pydoes work on Gaphor.