Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Text Wrapping for Requirement Name #322

Merged
merged 7 commits into from May 29, 2020
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented May 23, 2020

Signed-off-by: Dan Yeaw dan@yeaw.me

Small PR that wraps the requirement name text and centers it.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Work left to do:

  • Center text after on each line of the text box following wrapping

Signed-off-by: Dan Yeaw <dan@yeaw.me>
@github-actions github-actions bot added the feature A new feature label May 23, 2020
@danyeaw danyeaw added this to the 2.0 milestone May 23, 2020
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw requested a review from amolenaar May 24, 2020 18:53
gaphor/diagram/shapes.py Outdated Show resolved Hide resolved
gaphor/diagram/text.py Outdated Show resolved Hide resolved
gaphor/diagram/shapes.py Outdated Show resolved Hide resolved
gaphor/diagram/shapes.py Outdated Show resolved Hide resolved
gaphor/diagram/shapes.py Outdated Show resolved Hide resolved
gaphor/diagram/shapes.py Outdated Show resolved Hide resolved
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw
Copy link
Member Author

danyeaw commented May 29, 2020

@amolenaar Thanks for all the great feedback and backup!

@danyeaw danyeaw merged commit 35ce783 into master May 29, 2020
@danyeaw danyeaw deleted the feature/req-wrap-text branch May 29, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants