Add extra model integrity checks #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should not end up in the model. Also `bind()` has been removed: it opens a backdoor for invalid data.
This was
linked to
issues
May 24, 2020
7 tasks
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It used to be possible for diagram items to end up in the model. This leads to issues when loading models.
Issue Number: #286, #326
What is the new behavior?
Extra checks are done for the type sanity for both
Element Factory(which contains the model) andDiagram(where diagram items are added).This should ensure the model stays clean.
ElementFatctory.bind()has been removed since it was not used (nor tested).Does this PR introduce a breaking change?
Other information