Add the zoom buttons back #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Hi @amolenaar, these changes look great, thanks for adding these back!
Thinking about this fresh, would it make more sense for the zoom out to be on the left and zoom in on the right? Then it would progress from out to original to in from left to right, which would be more logical for me at least.
|
I agree, the other way around does make more sense 🙈 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Zoom button disappeared in the latest version. This PR adds them back
Issue Number: Fixes #3255
What is the new behavior?
Does this PR introduce a breaking change?
Other information