Replace macOS certificate import by a script #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
macos-certificates
branch
3 times, most recently
from
c4e842f
to
b3e0903
Compare
The gh action is outdated, and I think we have better control over what's going on.
It looks like something display related is not initialized on the 1st run.
amolenaar
force-pushed
the
macos-certificates
branch
from
775edcc
to
f4b19a7
Compare
danyeaw
approved these changes
Apr 29, 2024
|
Thanks @amolenaar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gh action is outdated, and I think we have better control over what's going on.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The action for certificate importing is outdated (Node 16). It's basically executing a script, so let's just do that: execute a script.
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information