Parts and references

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

No parts and references compartment in Block diagram

Issue Number: #138

What is the new behavior?

Parts and references are visible:

Does this PR introduce a breaking change?

• Yes
• No

NB. It looks like SysML elements are not visible in the tree view at all (!)

[danyeaw]

This looks really good, bravo! 🎉 I noticed one issue is that when you draw a white diamond association (shared association), it was showing up as a part property when it should be a reference property.

This can be part of another PR, but now that we have the two main types of properties for Blocks, I think we can either de-emphasize or remove completely Attributes and Operations. I guess it is technically possible for a Block to have these, but I don't think I have seen them added in practice. What do you think about us just removing them entirely from the BlockItem and the block property page?

[amolenaar]

I was a bit in doubt on the shared association. I'll change it accordingly.

[amolenaar]

Removing attributes and operations is trivial now, since Block is a separate diagram item now, not inheriting from ClassItem.

Isn't it custom to have attributes for, for example, maxPSI on an InflationValve and a thresholdPSI on a TirePressureMonitor?

(using American units here, we use Bar as unit for pressure 😃 )

[danyeaw]

Those would be added by a 3rd Property that we haven't created yet called a Value Property. To support those we would need to add some default ValueTypes and make it possible to add additional ones, since every value property is typed by a ValueType.

[amolenaar]

Then we'd better remove attributes and operations, before they are misused. Or maybe keep attributes until we have ValueTypes in place?

[danyeaw]

I would be ok with just removing them I think, and then once we get initial SysML support finished, we can come back in with additions like ValueTypes.

[amolenaar]

Fair enough. Sounds like a simple change to me.

[amolenaar]

I removed attributes and operations.