-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Download GTK instead of building #3302
Conversation
84b1c62
to
0b05565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This is a nice simplification on our end.
Does the Gvsbuild zip file contain everything that's part of that repo?
04a2829
to
68d1acb
Compare
68d1acb
to
7d32a7a
Compare
Hi @amolenaar it isn't everything, it is the core GTK libraries including libadwaita and GtkSourceView with gi enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. A nice simplification for people who want to develop on Gaphor on Windows.
This PR updates the CI/CD pipeline and dev environment instructions to directly download a pre-built version of GTK, rather than building it from source ourselves. The release of Gvsbuild today is the first one that distributed GTK as a release asset.
Also Step Security's Harden Runners only work with Ubuntu VMs, so I removed them for the Windows, macOS, and Fedora workflows.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have to rebuild GTK ourselves for Gaphor on Windows
Issue Number: N/A
What is the new behavior?
We download GTK and use it
Does this PR introduce a breaking change?
Other information