Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Download GTK instead of building #3302

Merged
merged 5 commits into from
May 11, 2024
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented May 10, 2024

This PR updates the CI/CD pipeline and dev environment instructions to directly download a pre-built version of GTK, rather than building it from source ourselves. The release of Gvsbuild today is the first one that distributed GTK as a release asset.

Also Step Security's Harden Runners only work with Ubuntu VMs, so I removed them for the Windows, macOS, and Fedora workflows.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

We have to rebuild GTK ourselves for Gaphor on Windows

Issue Number: N/A

What is the new behavior?

We download GTK and use it

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added chore Maintenance related PR and removed documentation labels May 10, 2024
@danyeaw danyeaw requested a review from amolenaar May 10, 2024 02:21
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is a nice simplification on our end.

Does the Gvsbuild zip file contain everything that's part of that repo?

.github/workflows/full-build.yml Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Show resolved Hide resolved
.github/workflows/full-build.yml Outdated Show resolved Hide resolved
@danyeaw danyeaw force-pushed the download-gtk-windows branch 2 times, most recently from 04a2829 to 68d1acb Compare May 10, 2024 23:13
@danyeaw
Copy link
Member Author

danyeaw commented May 11, 2024

Hi @amolenaar it isn't everything, it is the core GTK libraries including libadwaita and GtkSourceView with gi enabled.

@danyeaw danyeaw merged commit 37bbd33 into main May 11, 2024
18 checks passed
@danyeaw danyeaw deleted the download-gtk-windows branch May 11, 2024 20:00
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A nice simplification for people who want to develop on Gaphor on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants