Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gif file in Gaphor #331

Merged
merged 2 commits into from May 31, 2020
Merged

Update gif file in Gaphor #331

merged 2 commits into from May 31, 2020

Conversation

seryafarma
Copy link
Contributor

@seryafarma seryafarma commented May 31, 2020

Update the gif in the docs of Gaphor. The same sequence of usage is done in this new gif in comparison with the previous one.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: #329

What is the new behavior?

New gif based on the latest version of Gaphor.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Please give inputs whether there is any improvement points I can further make in the gif.

@seryafarma seryafarma changed the title docs: Update gif. Update gif file in Gaphor May 31, 2020
@danyeaw
Copy link
Member

danyeaw commented May 31, 2020

@seryafarma Thanks so much for the contribution!

Is this gif from Elementary OS? Although I have installed that distribution before to check it out, I haven't actually seen Gaphor running on it before, so that is cool. 👍

One thing that I noticed is that the updated inline editor using the Gtk.Entry isn't showing up like it does in GNOME:
image

That might be a bug. Is this the latest version from source or did you download a released version?

@danyeaw danyeaw added the chore Maintenance related PR label May 31, 2020
@danyeaw danyeaw linked an issue May 31, 2020 that may be closed by this pull request
7 tasks
@danyeaw danyeaw added this to the 1.3 milestone May 31, 2020
@seryafarma
Copy link
Contributor Author

Hi Danyeaw, I am actually using my zorinos laptop for making that gif. Do you need a specific gif based on a specific distro?

I installed Gaphor using flatpak as mentioned in the readme.

@seryafarma
Copy link
Contributor Author

I will make another gif file using my linux mint. It seems like gaphor shows the same inline update textbox when I use mint. Thanks for the input! Will update this PR.

@danyeaw
Copy link
Member

danyeaw commented May 31, 2020

@seryafarma That looks great, thanks again for the great contribution! 🎉

@danyeaw danyeaw merged commit 16ed98b into gaphor:master May 31, 2020
@amolenaar
Copy link
Member

@seryafarma Thanks a lot 🚀

@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README Animation
3 participants