Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part Properties on Diagrams #332

Merged
merged 10 commits into from Jun 11, 2020
Merged

Part Properties on Diagrams #332

merged 10 commits into from Jun 11, 2020

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented May 31, 2020 •
edited

This PR adds support for Internal Block Diagrams. The major elements for initial support is support for Part Property, Reference Property, Proxy Port, Connector on diagrams. This PR implements a portion of this:

  • Part properties are shown on a diagram as a box with a solid outline.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: Portion of #138

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@danyeaw
Comment in association test
88a03d1 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw
Add block, connector, and proxy port icons
1d5fd54 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw
Convert warning to f-string
1df7cf9 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw
Create initial property representation
01fc610 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@github-actions github-actions bot added the feature A new feature label May 31, 2020
@danyeaw danyeaw added this to the 2.0 milestone May 31, 2020
@danyeaw
Fix UML.Property is not a Classifier
4936824 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@sourcery-ai sourcery-ai bot mentioned this pull request Jun 2, 2020
Merged
danyeaw and others added 2 commits June 1, 2020 22:15
@danyeaw
Refactor code
61cfbba 
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@sourcery-ai @sourcery-ai-bot
Refactored by Sourcery (#338)
e32e8a9 
Co-authored-by: Sourcery AI <bot@sourcery.ai>
@amolenaar
Copy link
Member

Looks good 👍

@danyeaw danyeaw changed the title Implement Internal Block Diagrams Part Properties on Diagrams Jun 11, 2020
@danyeaw danyeaw marked this pull request as ready for review June 11, 2020 00:24
@danyeaw
Merge master
06cd4c4 
# Conflicts:
#	gaphor/UML/components/component.py
#	gaphor/ui/namespace.py
@danyeaw danyeaw merged commit 1c542f3 into master Jun 11, 2020
@danyeaw danyeaw deleted the feature/internal-block branch June 11, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolenaar amolenaar amolenaar left review comments

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danyeaw @amolenaar