Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Keybindings After Toolbox Changes #342

Merged
merged 3 commits into from Jun 3, 2020
Merged

Fix Keybindings After Toolbox Changes #342

merged 3 commits into from Jun 3, 2020

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jun 2, 2020 •
edited by danyeaw

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: #335

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar requested a review from danyeaw June 2, 2020 18:32
@amolenaar amolenaar added this to the 1.3 milestone Jun 2, 2020
@sourcery-ai sourcery-ai bot mentioned this pull request Jun 2, 2020
Merged
@github-actions github-actions bot added the fix A fix for a bug label Jun 2, 2020
@sourcery-ai @sourcery-ai-bot
Refactored by Sourcery (#343)
dd4e21e 
Co-authored-by: Sourcery AI <bot@sourcery.ai>
@danyeaw danyeaw changed the title Fix/toolbox shortcuts Fix Keybindings After Toolbox Changes Jun 3, 2020
@danyeaw
Copy link
Member

danyeaw commented Jun 3, 2020

This looks great!

@danyeaw danyeaw merged commit f96a619 into master Jun 3, 2020
@danyeaw danyeaw deleted the fix/toolbox-shortcuts branch June 3, 2020 01:06
@amolenaar amolenaar mentioned this pull request Jun 3, 2020
Closed
3 tasks
@amolenaar amolenaar linked an issue Jun 3, 2020 that may be closed by this pull request
Keybindings do not work after toolbox changed #335
Closed
3 tasks
@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
@danyeaw danyeaw added bug An issue in the application and removed fix A fix for a bug labels Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
bug An issue in the application
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Keybindings do not work after toolbox changed
2 participants
@amolenaar @danyeaw