Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show element editor by default #344

Merged
merged 9 commits into from Jun 4, 2020
Merged

Show element editor by default #344

merged 9 commits into from Jun 4, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: #339

What is the new behavior?

  • Element editor is shown by default
  • Extra text is shown with some usage tips
  • The editor section is now a scrolled window
  • Remove unused space on right side of window when element editor is collapsed
  • Fixed box spacing for boxes created via the layout class

image

image

Does this PR introduce a breaking change?

  • Yes
  • No

@sourcery-ai sourcery-ai bot mentioned this pull request Jun 3, 2020
Merged
@github-actions github-actions bot added the fix A fix for a bug label Jun 3, 2020
@amolenaar amolenaar requested a review from danyeaw June 3, 2020 19:57
@amolenaar amolenaar linked an issue Jun 3, 2020 that may be closed by this pull request
Show Element Editor by default #339
Closed
3 tasks
@amolenaar
Merge pull request #345 from gaphor/sourcery/fix/show-element-editor-…
c478ac9 
…by-default

Show element editor by default (Sourcery refactored)
@danyeaw
Copy link
Member

danyeaw commented Jun 4, 2020

Great idea to have some tips displayed! I think after I have seen this a couple of times that I would want to hide it. What if we added a checkbox under the No item selected font that by default was checked to Show Tips. Then if it is unchecked the tips aren't displayed?

@amolenaar
Copy link
Member Author

That's a nice addition. Having no tips will make the layout more clean again.

@amolenaar
Copy link
Member Author

image

@amolenaar amolenaar merged commit ec2d2c8 into master Jun 4, 2020
@amolenaar amolenaar deleted the fix/show-element-editor-by-default branch June 4, 2020 20:08
@danyeaw
Copy link
Member

danyeaw commented Jun 4, 2020

Awesome! 👍

@danyeaw danyeaw added bug An issue in the application and removed fix A fix for a bug labels Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
bug An issue in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Element Editor by default
3 participants
@amolenaar @danyeaw @sourcery-ai-bot