New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy port #349
Proxy port #349
Conversation
Looks great so far! |
@amolenaar Is this ready for review / merge? |
Not yet. I want to fix text placement first. |
@danyeaw Ok, ready for review 😃 |
Can be placed, no behaviour yet
Depending on the side the port is connected to, the text is placed on the top,left, right or bottom side of the port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amolenaar The code looks really good! I also really like the way the labels snap to the right position, very nice.
I noticed when trying it out that the proxy ports work great when attached to a Block, but don't work on a part or reference properties for me (which is the primary use case of proxy ports).
Ah. Thanks!
|
@danyeaw I need some help. A Proxy port is a subtype of Property. It can be linked to a Classifier. A Part or Reference Property is a property. I can not attach the port to the I figured that if you place a port It's unclear to me what relation should be created at model level when a Port is attached to a Part/Reference Property. Do you have an idea? Should it be done via a Connector internally? |
PR Type
What kind of change does this PR introduce?
Issue Number: #138
What is the new behavior?
A proxy port.
Still needs: