Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Reference Properties as Dashed #351

Merged
merged 5 commits into from Jun 17, 2020
Merged

Show Reference Properties as Dashed #351

merged 5 commits into from Jun 17, 2020

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jun 13, 2020

This is part of closing #138 in order to show Reference Properties with dashed borders instead of solid.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

All properties are shown as a rectangle with a solid line.

Issue Number: #138

What is the new behavior?

Reference Properties are shown as a rectangle with a dashed line.

Does this PR introduce a breaking change?

  • Yes
  • No

TODO

  • Update shape style when aggregation changes

Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw added the feature A new feature label Jun 13, 2020
@danyeaw danyeaw added this to the 2.0 milestone Jun 13, 2020
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw
Copy link
Member Author

danyeaw commented Jun 13, 2020

image

@danyeaw danyeaw marked this pull request as ready for review June 13, 2020 20:22
@danyeaw danyeaw requested a review from amolenaar June 13, 2020 20:22
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaphor/SysML/blocks/property.py Show resolved Hide resolved
gaphor/SysML/blocks/property.py Outdated Show resolved Hide resolved
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw
Copy link
Member Author

danyeaw commented Jun 17, 2020

@amolenaar Thanks for the feedback!

@danyeaw danyeaw merged commit 6f77060 into master Jun 17, 2020
@danyeaw danyeaw deleted the dashed-reference branch June 17, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants