Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fancy DMG #353

Merged
merged 2 commits into from Jun 25, 2020
Merged

Fancy DMG #353

merged 2 commits into from Jun 25, 2020

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jun 23, 2020 •
edited

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

The DMG contains only the application, not the fancy content you're used to when opening a Dmg.

What is the new behavior?

Icons are placed in more central location. A link to /Applications is added.

image

@amolenaar
Use dmgbuild to create the image
5166e45 
Now we can make it look like a true MacOS DMG.
@amolenaar amolenaar requested a review from danyeaw June 24, 2020 21:06
@amolenaar amolenaar added this to the 1.3 milestone Jun 24, 2020
@danyeaw danyeaw added the feature A new feature label Jun 25, 2020
@danyeaw danyeaw merged commit e0274c3 into master Jun 25, 2020
@danyeaw danyeaw deleted the fancy-dmg branch June 25, 2020 00:55
@danyeaw
Copy link
Member

danyeaw commented Jun 25, 2020

Very nice! 🎉

@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amolenaar @danyeaw