Css pseudo states #358
Merged
Css pseudo states #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
css-pseudo-states
branch
from
2cd08e4
to
9ab45b9
Compare
We want to know the state of all elements when processing CSS rules.
E.g. `node:active component {}`
amolenaar
force-pushed
the
css-pseudo-states
branch
2 times, most recently
from
8668e6e
to
9776ee3
Compare
danyeaw
approved these changes
Jul 6, 2020
pyproject.toml
Outdated
| @@ -35,7 +35,9 @@ classifiers = [ | |||
| python = "^3.7" | |||
| pycairo = "^1.18" | |||
| PyGObject = "^3.30" | |||
| gaphas = "^2.1" | |||
| #gaphas = "^2.1" | |||
| gaphas = { git = "https://github.com/gaphor/gaphas.git", branch = "master" } | |||
There was a problem hiding this comment.
I'm sure you're on top of it, but just a reminder to not forget to change this back now that you released a new version
There was a problem hiding this comment.
I wanted to make sure I do not need to make more changes to Gaphas before creating a new Gaphas release.
|
I'm not finished yet. There's still some tough nuts to crack. I moved the style lookup out of the Presentation class, since I also need to add state info (focused, selected). This information lives in the View. Styling information is used in 2 places:
The ItemWrapper (bad name) objects should have a reference to the view, since they need to look up state information for the rendered item, but possible also for its parent and children. From a conceptual point of view it makes sense to let Diagram own (or reference) a style sheet. |
* Require Gaphas 2.1.1 (master) code * Everything styling related to gaphor.core.styling. * Provide style data through update/draw contexts * Style is requested via the diagram object * Use Style type all around
Makes more sense than going via the canvas
Also defined a protocol for the style node.
Each item type should bring its own style node implementation (wrapper).
Since that's how it's defined for HTML as well.
amolenaar
force-pushed
the
css-pseudo-states
branch
from
9776ee3
to
3964dfd
Compare
|
View states now translate to pseudo-classes in CSS.
|
Fallback styles is only needed for diagram items.
|
I also added support for styling of the diagram background and line style. Sloppy-line setting is gone from the preferences window
|
Now I can change background color based on elements in the diagram:
diagram:has(classitem) {
background-color: beige;
}
Remove vertical-align|spacing from fallback CSS.
No need to implement this in 2 places.
Avoid name conflicts
Did not know that code was in tinycss2 as well.
amolenaar
force-pushed
the
css-pseudo-states
branch
from
d5bbce8
to
9a0fb75
Compare
amolenaar
force-pushed
the
css-pseudo-states
branch
from
9a0fb75
to
7a6889a
Compare
Sourcery Code Quality Report (beta)✅ Merging this PR will increase code quality in the affected files by 0.03 out of 10.
Here are some functions in these files that still need a tune-up:
Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Style can be defined, but style can not be changed on the view state of an item (focused, selected, etc.).
Issue Number: #284
What is the new behavior?
Style will be updated based on the view state of an item.
Does this PR introduce a breaking change?
Other information
This PR does some serious rearrangement of code:
gaphor.core.styling(also the code previously ingaphor.diagram.style).