Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSS attributes #360

Merged
merged 1 commit into from Jul 14, 2020
Merged

Support CSS attributes #360

merged 1 commit into from Jul 14, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

Issue Number: #284

What is the new behavior?

Define rules based on attributes.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 13, 2020

Sourcery Code Quality Report (beta)

❌ Merging this PR will decrease code quality in the affected files by 0.15 out of 10.

Before After Change
Quality 9.3 9.15 -0.15
Complexity 0.9 1.18 0.28
Method Length 24.84 30.05 5.21
Lines 229 322 93
Changed files Quality Before Quality After Quality Change
gaphor/core/modeling/diagram.py 9.3 9.15 -0.15 ⬇️
gaphor/core/modeling/tests/conftest.py N/A 9.88 N/A
gaphor/core/modeling/tests/test_style_attributes.py N/A 9.05 N/A

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@amolenaar amolenaar requested a review from danyeaw July 13, 2020 20:53
@amolenaar amolenaar merged commit e834f05 into master Jul 14, 2020
@amolenaar amolenaar deleted the css-attributes branch July 14, 2020 08:43
@danyeaw danyeaw added the feature A new feature label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants