Css always have a stylesheet

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

One needs to enable a toggle to enable the style sheet. This is very confusing. For me even, and I wrote the feature!

Issue Number: #284

What is the new behavior?

Diagram is in charge of ensuring there's always a style sheet to use.

Also the last remaining preference option (reset tool) has been moved to the settings pane. Now all settings are in one place.

The settings pane contains a link to documentation on Style sheets, so people can learn about them. Just a text field is not much use.

Does this PR introduce a breaking change?

• Yes
• No

Other information

I have a solid background in CSS. It would be nice if the new workflow and CSS documentation is reviewed by someone less familiar with CSS.

[sourcery-ai]

Sourcery Code Quality Report (beta)

❌ Merging this PR will decrease code quality in the affected files by 0.02 out of 10.

	Before	After	Change
Quality	8.76	8.74	-0.02
Complexity	1.34	1.35	0.02
Method Length	49.17	50.15	0.98
Lines	2938	2840	-98

Changed files	Quality Before	Quality After	Quality Change
gaphor/UML/classes/tests/test_classconnect.py	7.97	7.97	0.0
gaphor/core/modeling/diagram.py	9.3	9.29	-0.01 ⬇️
gaphor/core/modeling/tests/test_diagram.py	9.52	9.52	0.0
gaphor/diagram/shapes.py	8.77	8.77	-0.0
gaphor/diagram/tests/test_copypaste.py	8.39	8.39	0.0
gaphor/plugins/diagramexport/init.py	8.85	8.85	-0.01 ⬇️
gaphor/storage/storage.py	7.71	7.71	0.0
gaphor/storage/tests/test_storage.py	8.26	8.26	0.0
gaphor/ui/elementeditor.py	9.04	9.11	0.07 ⬆️
gaphor/ui/mainwindow.py	8.84	8.84	0.0
gaphor/ui/tests/test_diagrampage.py	9.29	9.22	-0.07 ⬇️
tests/test_undo.py	9.06	9.06	0.0

Here are some functions in these files that still need a tune-up:

File	Function	Quality	Recommendation
gaphor/storage/storage.py	save_generator	2.3	Split out functionality
gaphor/storage/storage.py	_load_elements_and_canvasitems	4.6	Split out functionality
gaphor/storage/tests/test_storage.py	StorageTestCase.test_save_and_load_model_with_relationships	5.24	Split out functionality
gaphor/storage/storage.py	load_generator	5.53	Split out functionality
gaphor/ui/mainwindow.py	MainWindow.open	5.61	Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

[amolenaar]

[actionless]

looks great, thanks a lot!
i'll try to give it a test during this week (a bit busy last days)

[amolenaar]

@actionless Thanks a lot. Please let me know what you think.