Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Style Sheet Documentation #362

Merged
merged 1 commit into from Jul 17, 2020
Merged

Polish Style Sheet Documentation #362

merged 1 commit into from Jul 17, 2020

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jul 17, 2020

Signed-off-by: Dan Yeaw dan@yeaw.me

This PR helps polish some of the style sheet doc formatting, spelling, and language.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw requested a review from amolenaar July 17, 2020 02:13
@github-actions github-actions bot added the chore Maintenance related PR label Jul 17, 2020
@danyeaw danyeaw added this to the 2.0 milestone Jul 17, 2020
@amolenaar
Copy link
Member

Thanks. This is a lot better.

PS. I noticed though we start of in a "third person", then move to "we" and after that address the reader directly ("you"). I'm not a tech writer by any means, so it may be something to dig into (some tech-writing guidelines, that is).

@amolenaar amolenaar merged commit 316ff8a into master Jul 17, 2020
@amolenaar amolenaar deleted the chore/css-doc-edits branch July 17, 2020 19:06
@danyeaw
Copy link
Member Author

danyeaw commented Jul 18, 2020

@amolenaar Yes, I think ideally things should be in the active voice. I agree that the docs aren't always consistent at this, but we can try to improve that overtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants