Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part connector (Sourcery refactored) #364

Merged
merged 1 commit into from Jul 20, 2020

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Jul 17, 2020

Pull Request #363 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the part-connector branch, then run:

git fetch origin sourcery/part-connector
git merge --ff-only FETCH_HEAD
git reset HEAD^

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Jul 20, 2020

Sourcery Code Quality Report (beta)

✅  Merging this PR will increase code quality in the affected files by 0.04 out of 10.

Quality metrics Before After Change
Complexity 1.29 1.00 -0.29 🔵
Method Length 33.42 33.28 -0.14 🔵
Quality 9.05 9.09 0.04 🔵
Other metrics Before After Change
Lines 66 64 -2
Changed files Quality Before Quality After Quality Change
gaphor/SysML/blocks/connectors.py 9.05 9.09 0.04 🔵

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@amolenaar amolenaar merged commit 61cd9ce into part-connector Jul 20, 2020
@amolenaar amolenaar deleted the sourcery/part-connector branch July 20, 2020 08:01
@danyeaw danyeaw added the chore Maintenance related PR label Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants