Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Packaging Fails for Missing Files #375

Merged
merged 3 commits into from Jul 30, 2020
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jul 28, 2020

PyInstaller was unable to find the tinycss2/VERSION file.
Adds two PyInstaller hooks to collect the data files. These hooks can be removed once I get them in to a released version of https://github.com/pyinstaller/pyinstaller-hooks-contrib.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Gaphor fails to launch after installed in Windows.

Issue Number: N/A

What is the new behavior?

Gaphor launches again 馃帀

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

PyInstaller was unable to find the tinycss2/VERSION file.
Add hook to collect the data files.
@danyeaw danyeaw added the bug An issue in the application label Jul 28, 2020
@danyeaw danyeaw added this to the 2.0 milestone Jul 28, 2020
@danyeaw danyeaw requested a review from amolenaar July 28, 2020 02:15
@amolenaar
Copy link
Member

We do not use cssselect2 anymore. I think we do not need a hook for that one.

Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. No need for cssselect2, though. It's not used.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 30, 2020

Sourcery Code Quality Report (beta)

This PR has an average code quality of 9.80 out of 10

Quality metrics Before After Change
Complexity 0.00
Method Length 8.00
Quality **** 9.80 ****
Other metrics Before After Change
Lines 5
Changed files Quality Before Quality After Quality Change
win-installer/hooks/hook-tinycss2.py 9.80

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@danyeaw danyeaw merged commit 8caeaaa into master Jul 30, 2020
@danyeaw danyeaw deleted the bug/fix-win-installer branch July 30, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants