Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DMG with create-dmg instead of dmgbuild #381

Merged
merged 2 commits into from Jul 31, 2020
Merged

Create DMG with create-dmg instead of dmgbuild #381

merged 2 commits into from Jul 31, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Builds are failing on DMG creation when using dmgbuild.

What is the new behavior?

Use create-dmg to achieve the same.

https://github.com/create-dmg/create-dmg

@amolenaar amolenaar requested a review from danyeaw July 30, 2020 13:36
@amolenaar amolenaar force-pushed the create-dmg branch 3 times, most recently from 5825278 to cd2f4aa Compare July 30, 2020 17:58
@amolenaar
Copy link
Member Author

create-dmg looks stable on GitHub Actions.

image

danyeaw
danyeaw approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of the background image!

@danyeaw danyeaw merged commit df9032f into master Jul 31, 2020
@danyeaw danyeaw deleted the create-dmg branch July 31, 2020 01:02
@danyeaw danyeaw added the bug An issue in the application label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
bug An issue in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amolenaar @danyeaw