Fix Gaphor Launching Fails in macOS #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
What I try to solve is why Gaphor will not open a model via finder (e.g. double-click on the desktop).
What is the new behavior?
Gaphor is started via a binary, instead of a shell script. This ought to fix the loading issue, but there's more going on.
As a plus I get logging in the Console.app at least. That alone makes the change worth it.
Does this PR introduce a breaking change?
Other information
I took some stuff from py2app. We may want to start using that as our starting point for packaging on macOS at some point.
When I click on a model, I get the following dialog (served from Gaphor by looking at the menu bar):
Edit: Solved! The file-open events from macOS do not reach the application. I had to add gtk-mac-integration to handle the file-open event, as well as the quit event from the dock icon.