Fix UML composite and shared association #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the UML Composite and Share Association tools was only creating a normal association. To resolve, copied the SysML implementation, and refactored some of the functions in to the UML toolbox module to prevent duplication. Signed-off-by: Dan Yeaw <dan@yeaw.me>
amolenaar
approved these changes
Aug 18, 2020
danyeaw
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the UML Composite and Share Association tools was only creating a normal association. To resolve this, I copied the SysML implementation, and refactored some of the functions in to the UML toolbox module to prevent duplication.
Signed-off-by: Dan Yeaw dan@yeaw.me
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
UML composite and shared association tools create a normal association.
Issue Number: closes #396
What is the new behavior?
This issue is resolved, the composite and share associations are created properly.
Does this PR introduce a breaking change?
Other information