Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run console tests as well #416

Merged
merged 2 commits into from Aug 25, 2020
Merged

Run console tests as well #416

merged 2 commits into from Aug 25, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Console tests are not run.

What is the new behavior?

I thought I fixed it.

@amolenaar amolenaar marked this pull request as draft August 25, 2020 07:08
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 25, 2020

Sourcery Code Quality Report (beta)

❌  Merging this PR will decrease code quality in the affected files by 0.02 out of 10.

Quality metrics Before After Change
Complexity 0.00 0.00 0.00
Method Length 26.65 27.23 0.58 🔴
Quality 9.35 9.33 -0.02 🔴
Other metrics Before After Change
Lines 53 46 -7
Changed files Quality Before Quality After Quality Change
gaphor/plugins/console/tests/test_console.py 9.35 9.33 -0.02 🔴

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@amolenaar amolenaar marked this pull request as ready for review August 25, 2020 08:42
@amolenaar amolenaar merged commit fc9bc11 into master Aug 25, 2020
@amolenaar amolenaar deleted the run-console-tests-in-ci branch August 25, 2020 08:42
@amolenaar amolenaar added this to the 2.0.1 milestone Aug 25, 2020
@amolenaar amolenaar added the chore Maintenance related PR label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant