Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyInstaller Packaging Issues #424

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Aug 31, 2020

This PR fixes three issues with PyInstaller:

  1. GTK started linking to HarfBuzz with Gtk and Pango. I added a hook to work around this until a new version of PyInstaller is released, the original issue is at GTK in Windows: Typelib for HarfBuzz version '0.0' is not found pyinstaller/pyinstaller#5129
  2. Although the tinycss2 hook is now integrated with the pyinstaller-hooks-contrib package, we aren't yet using PyInstaller 4.0 because of a separate issue. I added back in this hook for us. Tinycss2 is also working on a new release which will get rid of the need for a hook at all.
  3. Windows MSYS2 uses an older version of setuptools which has an issue around use of py2.warn.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Windows packages won't launch

Issue Number: N/A

What is the new behavior?

They launch now

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw requested a review from amolenaar August 31, 2020 12:35
@danyeaw danyeaw added the bug An issue in the application label Aug 31, 2020
@amolenaar amolenaar merged commit 75d8bf9 into master Sep 1, 2020
@amolenaar amolenaar deleted the bug/pyinstaller-issues branch September 1, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants