Cleanup session lifecycle #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Application works in line (sort of) of now a session works.
The loading behavior should now be consistent (e.g. replace model in current session if it has a new model without modifications.
Sourcery Code Quality Report (beta)❌ Merging this PR will decrease code quality in the affected files by 0.03 out of 10.
Here are some functions in these files that still need a tune-up:
Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There was a lot of hopping around the code when dealing with file loading and session creation. This was only possible through the
GtkApplication. This is inconvenient and not handy, sinceGtkApplicationis not out core application:gaphor.application.Applicationis.Issue Number: N/A
What is the new behavior?
This PR cleans up the code. Makes sure all file loading takes place through the
app_file_managerand ensures session lifecycle can be completely handled in our code.On application level there's also an event manager now, so session creation and application shutdown events can be propagated to the GtkApplication as well. Handlers in GtkApplication ensure that the main window is shown when a new session is created and make sure the Gtk main loop is ended when the Gaphor Application ends.
Does this PR introduce a breaking change?