Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine namespacing #461

Merged
merged 4 commits into from
Sep 28, 2020
Merged

State machine namespacing #461

merged 4 commits into from
Sep 28, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

State machine elements were shown in the root of the tree view.

Issue Number: #386

What is the new behavior?

State machines elements (state, transition) are put in a state machine in a (default) region.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • Adds icon for Constraint (used by Transition)

Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one test that can be cleaned up.

gaphor/UML/tests/test_state_machine.py Outdated Show resolved Hide resolved
@amolenaar amolenaar merged commit 9a9d5a3 into master Sep 28, 2020
@amolenaar amolenaar deleted the state-machine-namespacing branch September 28, 2020 19:16
@danyeaw danyeaw added the feature A new feature label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants