Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos build #502

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Fix macos build #502

merged 2 commits into from
Oct 26, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The build breaks: Homebrew has updated our dependency (gobject-introspection) to depend on Python 3.9

What is the new behavior?

The Python version is determined on the Python used by gobject-introspection. This way the build should no longer break on Python updates.

Does this PR introduce a breaking change?

  • Yes
  • No

GObject-introspection is dependent on Python. That's
the version we will install. Ensure we use that Python
version.
@danyeaw danyeaw merged commit 747fdfb into master Oct 26, 2020
@danyeaw danyeaw deleted the fix-macos-build branch October 26, 2020 22:29
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @amolenaar !

@danyeaw danyeaw added the chore Maintenance related PR label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants