Connect start of line when placed inside an element

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

The line end is connected to an element when placed on a diagram. The line head is not.

Issue Number: N/A

What is the new behavior?

Also connect line head after a line is connected.

Other information

To reproduce:

1. create 2 classes
2. Draw an Association from the center of class 1 to the center of class 2
3. The association should connect on both sides.

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.08%.

Quality metrics	Before	After	Change
Complexity	2.92 ⭐	2.79 ⭐	-0.13 👍
Method Length	44.07 ⭐	43.44 ⭐	-0.63 👍
Working memory	7.10 🙂	7.14 🙂	0.04 👎
Quality	79.88% ⭐	79.96% ⭐	0.08% 👍

Other metrics	Before	After	Change
Lines	168	172	4

Changed files	Quality Before	Quality After	Quality Change
gaphor/diagram/diagramtools/grayout.py	85.67% ⭐	86.84% ⭐	1.17% 👍
gaphor/diagram/diagramtools/placement.py	78.23% ⭐	77.82% ⭐	-0.41% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gaphor/diagram/diagramtools/placement.py	on_drag_end	1 ⭐	57 ⭐	10 😞	74.38% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[danyeaw]

This looks great!