Update Diagrams to Open in Gtk.Notebook Pages #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
When closing a tab or exiting the app, it was throwing the above GTK-CRITICAL error. This error was resolved by unshowing the tabs prior to removing a page, and then showing them again after the page is removed. I need to look in to more why this is necessary. Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
The updated main window always displays the Toolbox and Namespace, so an option to show them is not needed. Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
danyeaw
changed the title
|
Updating this to work-in-progress. There are some other areas like the auto diagram formatter that also depends on the diagram page, so I would like to make some more updates prior to merging this. |
amolenaar
approved these changes
Jan 11, 2019
gaphor/ui/mainwindow.py
Outdated
| @@ -777,7 +662,7 @@ def tree_view_create_package(self): | |||
|
|
|||
| @action( | |||
| name="tree-view-delete-package", | |||
| label=_("Delete pac_kage"), | |||
| label=_("Delete package"), | |||
There was a problem hiding this comment.
Why did you drop the underscore? This used to be used for quick access keys in the menu. Is that no longer working like that?
There was a problem hiding this comment.
Thanks for the correction, that's definitely why I needed your help reviewing this. I just figured it was a typo 😄
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
The toolbox was using a custom wrapbox that provided similar functionality to the Gtk ToolPalette widget. Switched to the base Gtk+ widget to improve Gtk compatibility and fix the wrapbox not wrapping the buttons down to the next row when shrinking the toolbox. Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Refactored the hand draw style action from the MainWindow to the Diagram class, since the action was unable to get the list of tabs from the MainWindow. Signed-off-by: Dan Yeaw <dan@yeaw.me>
danyeaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to what @amolenaar started by completing some of the conversion to make the main window use a normal Gtk.Notebook. It now works to open and close multiple diagrams.
@amolenaar How do I launch the checkmetamodel plugin to test that it is working correctly? When I try to run
python checkmodelgui.py, it immediately closes.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: continue work towards fixing #49
What is the new behavior?
Does this PR introduce a breaking change?
Other information