Clean up branch (Cut-intro) Don't merge yet #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lettmann
changed the title
Lettmann
changed the title
gebner
reviewed
Mar 16, 2017
| @@ -105,6 +105,11 @@ abstract class Expr { | |||
| */ | |||
| def find( exp: Expr ): List[HOLPosition] = getPositions( this, _ == exp ) | |||
|
|
|||
| /* | |||
| Tests whether an expression is a subexpression. | |||
| def contains( exp: Expr ): Boolean = {} | |||
There was a problem hiding this comment.
This seems like a reasonable addition. You could implement it using the find method that's right above it.
There was a problem hiding this comment.
Actually, that is the point why I mentioned it. I thought that there should be a better way of implementing this than using positions (given that positions should not be necessary to do so)
…als whether they contain only alphas, betas, or none.
|
@Lettmann Sorry, I know you didn't want this PR to be merged yet, but I need the cleaned-up version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.