fix(git): fix exclude files handling in subtree Git repo scan mode
#5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/5317-fix-excluded-files-changes-trigger-rebuild
branch
from
f153957
to
feff09f
Compare
vvagaytsev
force-pushed
the
fix/5317-fix-excluded-files-changes-trigger-rebuild
branch
from
27d521b
to
3783731
Compare
vvagaytsev
changed the title
exclude files in Git repo scanning
vvagaytsev
changed the title
exclude files in Git repo scanningexclude files config in Git repo scanning
vvagaytsev
changed the title
exclude files config in Git repo scanningexclude files handling in subtree Git repo scan mode
vvagaytsev
force-pushed
the
fix/5317-fix-excluded-files-changes-trigger-rebuild
branch
from
497b9b9
to
8eca06b
Compare
Full (prefix and postfix) glob pattern for exclude filter
Normalize the excluded relative paths with redundant `..` and `.` parts. This ensures that `--glob-pathspecs` Git flag will behave properly with `--exclude` arg. This fix prevent rebuilding container module on excluded files modification.
vvagaytsev
force-pushed
the
fix/5317-fix-excluded-files-changes-trigger-rebuild
branch
from
8eca06b
to
358850f
Compare
TimBeyer
reviewed
Dec 6, 2023
First, process inclusions, and then exclusions. For more clarity and consistency in the comments.
TimBeyer
approved these changes
Dec 6, 2023
vvagaytsev
deleted the
fix/5317-fix-excluded-files-changes-trigger-rebuild
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5317
Special notes for your reviewer:
Based on test fixes made in #5472.
See individual commits for details.