test(git): advanced test cases for include/exclude filters #5472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/5317-excluded-files-changes-trigger-rebuild
branch
5 times, most recently
from
86724cf
to
a2a6237
Compare
vvagaytsev
changed the title
vvagaytsev
force-pushed
the
fix/5317-excluded-files-changes-trigger-rebuild
branch
6 times, most recently
from
6cf5c57
to
03b8d33
Compare
This was referenced Nov 28, 2023
vvagaytsev
force-pushed
the
fix/5317-excluded-files-changes-trigger-rebuild
branch
12 times, most recently
from
e144b09
to
19f2003
Compare
vvagaytsev
changed the title
vvagaytsev
force-pushed
the
fix/5317-excluded-files-changes-trigger-rebuild
branch
3 times, most recently
from
d99ef0d
to
8d6b780
Compare
To make sure include filter behaves equally when exclude is empty and undefined
When the filename matches the filter, but the file path does not.
This does not make much sense. Hashes must be verified in the disk-based test projects. This makes the results fo the failed tests more readable.
To test the function against both `VcsHandler` implementations: - `GitHandler` - `GitRepoHandler`
Make sure the same scan mode is used in all git handlers created while testing.
stefreak
approved these changes
Dec 4, 2023
| { | ||
| name: "when directory is included by name with globs", | ||
| // FIXME: shouldn't just '**/deepdir' work well too? | ||
| pathBuilder: (_subDirName: string, deepDirName) => join("**", deepDirName, "**", "*"), |
There was a problem hiding this comment.
It would be good to use both path.posix.join and path.win32.join in the future for tests, to make sure that we are compatible with both backslashes and forward slashes.
There was a problem hiding this comment.
Sure, I can add it in the next PR.
@stefreak, no, those might be related to a separate bug. In the next PR I'll add test cases and fix for #5317. Let's see if that change fix also fixes the FIXME comments. |
vvagaytsev
force-pushed
the
fix/5317-excluded-files-changes-trigger-rebuild
branch
from
b4aacd4
to
b1462fa
Compare
vvagaytsev
deleted the
fix/5317-excluded-files-changes-trigger-rebuild
branch
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In this PR:
Which issue(s) this PR fixes:
Special notes for your reviewer: