fix(core): avoid unnecessary config version changes #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
narrow-config-version
branch
from
27995ef
to
97f8556
Compare
|
Does this also happen to fix #5501? |
|
@stefreak it looks like it does. |
vvagaytsev
force-pushed
the
narrow-config-version
branch
from
97f8556
to
1dcd082
Compare
vvagaytsev
force-pushed
the
narrow-config-version
branch
2 times, most recently
from
b9e89ff
to
f7b5866
Compare
For simpler testability.
vvagaytsev
force-pushed
the
narrow-config-version
branch
from
f7b5866
to
ce8497a
Compare
chore: type import chore: amend
vvagaytsev
force-pushed
the
narrow-config-version
branch
from
ce8497a
to
a595618
Compare
vvagaytsev
force-pushed
the
narrow-config-version
branch
from
a595618
to
3ed344b
Compare
TimBeyer
reviewed
Dec 6, 2023
TimBeyer
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5501
Fixes #5519
Special notes for your reviewer: